Caideyipi commented on PR #19014:
URL: https://github.com/apache/iotdb/pull/19014#issuecomment-6407879621

   self-review passed for `7046299764f`.
   
   Reviewed the complete diff and the relevant TTL write, query, procedure, and 
cache paths on `dev/1.3`. No actionable issues were found; no fixes were needed.
   
   This is an exact backport of `b652dddf41c41a86329845fac4214ec034a87575`: 
`IoTDBTtlIT.java` has identical Git blobs on both branches before and after the 
change. The widened time windows preserve the intended TTL filtering, and both 
UNSET cases insert timestamps outside the previous TTL. On this branch, 
successful SET/UNSET waits for the procedure and DataNode cache updates, 
supporting removal of the two post-UNSET sleeps.
   
   Validation:
   
   - `git diff --check` for the full PR diff: passed.
   - Fresh compilation of `IoTDBTtlIT.java` with JDK 17 (`javac --release 17`): 
passed.
   - Fresh local JUnitCore execution of `IoTDBTtlIT`, with `TestEnv=Cluster1`, 
`ClusterConfigurations=HighPerformanceMode` (1 ConfigNode, 3 DataNodes), random 
write-node selection, and reads verified across nodes: **passed**, `OK (1 
test)`, 25.137 seconds. The first isolated launch omitted test-framework 
helpers from the classpath and failed during initialization; after correcting 
the harness, the rerun passed.
   - This focused run reused existing `dev/1.3` runtime artifacts and 
dependencies. Full build, RAT, and formatter were not rerun; this review made 
no source changes. Remote hosts were occupied, so local fallback was used.
   - GitHub checks at review time: 6 passed, 2 skipped, 8 still running. 
Overall CI completion remains pending.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to