Caideyipi commented on PR #17850:
URL: https://github.com/apache/iotdb/pull/17850#issuecomment-6408137368

   Self-review passed.
   
   I reviewed the full PR diff and fixed two correctness issues in 
`939d153bdf9`:
   
   - `IN` constant folding now normalizes numeric containers and uses numeric 
comparison for mixed SQL numeric types, so folded arithmetic matches literal 
values.
   - Numeric comparisons now reject NaN operands, including `<>`, matching 
`CompareBinaryColumnTransformer`.
   
   Verification:
   
   - `spotless:apply -P with-integration-tests`: passed.
   - English source compile/install path with the constrained 2 GB retry: 
passed; `InsertValuesTest`: 5/5.
   - Chinese full-reactor `test-compile -P with-zh-locale`: passed.
   - Direct Failsafe execution: `IoTDBInsertTableIT` 3/3 and 
`IoTDBSessionRelationalIT` 2/2 passed.
   - The standard `verify -pl integration-test -am` path was blocked by the 
unrelated pre-existing `DropPipeProcedureTest` test-compilation error; the 
direct Failsafe run completed the five requested methods successfully.
   - The earlier PR Sonar job failed inside the scanner with the 
`NOPLoggerFactory`/`LoggerContext` incompatibility, so that CI check is not 
claimed as passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to