Caideyipi commented on PR #17850:
URL: https://github.com/apache/iotdb/pull/17850#issuecomment-6785276618

   Addressed both review comments in `05899a3a9c2aca79861ede7bc2d2e5560021dc99`.
   
   - All four numeric arithmetic helpers now use exhaustive switch expressions 
without a default.
   - Unexpected numeric comparison operators throw an exception instead of 
returning `null`.
   
   Validation passed: Spotless, the clean English DataNode dependency reactor 
with `InsertValuesTest` (6 passed), and the clean Chinese DataNode 
dependency-reactor test compilation. Build-result caching was disabled. 
Integration tests were not rerun for this update.
   
   Regarding the [Codecov 
report](https://github.com/apache/iotdb/pull/17850#issuecomment-4628424016): it 
reports coverage for the earlier `5960402` revision. The checks above do not 
establish a patch coverage percentage for this commit; updated coverage is 
tracked by CI.
   
   Comment-handling baseline: `266968aeb16d094b94dcca0182b8a156a94225b1`. Final 
local, source-branch, and PR heads were verified as 
`05899a3a9c2aca79861ede7bc2d2e5560021dc99`. This was a focused comment update, 
not a full independent self-review. The PR remains a draft pending an 
independent review of the latest full diff. I left the review discussions 
unresolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to