Caideyipi commented on code in PR #17925:
URL: https://github.com/apache/iotdb/pull/17925#discussion_r4374537446
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeUtils.java:
##########
@@ -332,16 +333,41 @@ public static void validateSchema(
boolean hasFailedMeasurement = insertStatement.hasFailedMeasurements();
String partialInsertMessage;
if (hasFailedMeasurement && !analysis.isFinishQueryAfterAnalyze()) {
+ final List<String> failedMeasurements = new ArrayList<>();
+ final List<String> failedMessages = new ArrayList<>();
+ collectDistinctFailedMeasurementMessages(
+ insertStatement.getFailedMeasurements(),
+ insertStatement.getFailedMessages(),
+ failedMeasurements,
+ failedMessages);
partialInsertMessage =
String.format(
- "Fail to insert measurements %s caused by %s",
- insertStatement.getFailedMeasurements(),
insertStatement.getFailedMessages());
+ "Fail to insert measurements %s caused by %s",
failedMeasurements, failedMessages);
Review Comment:
[P2] 部分插入汇总消息仍绕过中文 locale。这里保留的英文模板同时用于日志和返回给客户端的 TSStatus,`with-zh-locale`
下也会输出 `Fail to insert measurements ... caused by ...`。按项目的 i18n 规则,应把这个完整模板放入
en/zh 的同名 DataNodeQueryMessages 常量;本 PR 新增的两处状态消息断言也需要使用对应 locale
的模板。英文输出应保持兼容,中文输出应实际验证。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]