Caideyipi commented on PR #19022: URL: https://github.com/apache/iotdb/pull/19022#issuecomment-6424996033
Self-review passed for `1c2c6d13b57d45794bf278cbf79d041a71ec59d9`. Reviewed the complete diff and the worker sleep/wake-up, parser admission notification, and test cancellation/cleanup context. No actionable issues were found; no fixes were needed. This PR modifies an existing test and adds no new tests. Validation performed during this review on Linux with JDK 17: - `git diff --check` passed. - `mvn -o -T 2 clean test -pl iotdb-core/datanode -am -Dtest=PipeProcessorSubtaskWorkerTest -Dsurefire.failIfNoSpecifiedTests=false` passed using dedicated empty global/user Maven settings and `GITHUB_ACTIONS=true` to disable the configured build cache. All 28 reactor modules succeeded; all 6 worker tests passed with no failures, errors, or skips. The log confirmed 482 goals executed and 0 cache hits. - The full unit-test suite was not run. An initial online attempt was stopped after snapshot metadata transfers stalled; the final offline clean run above passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
