Caideyipi commented on PR #19022:
URL: https://github.com/apache/iotdb/pull/19022#issuecomment-6431941898
Self-review passed for the latest commit,
`3c1a53cb44cd07f187bed59a8e2b72fc8023e260` (diff against
`1c2c6d13b57d45794bf278cbf79d041a71ec59d9`). The previously reviewed
worker-test commit was excluded, as requested.
Reviewed the complete latest-commit diff and the relevant LOAD/replay, local
file layout, ordinary/aligned TsFile reads, duplicate-copy checks, bounded
waiting, and cleanup context. No actionable issues were found; no fixes were
needed. No tests were added.
Actual validation during this review on Linux with JDK 17:
- `git diff --check HEAD^ HEAD` passed.
- A clean reactor `verify` of `integration-test` and its IoTDB dependency
closure passed: all 37 modules succeeded, and all 841 goals were executed. The
run used Maven offline mode, dedicated empty global/user settings, and
`GITHUB_ACTIONS=true` to disable the configured build cache.
- Failsafe confirmed
`IoTDBLoadTsFileClusterIT#testRestartedDataNodeIsSyncedWithTheLoadedFile` ran:
1 test, 0 failures, 0 errors, 0 skips. Surefire was explicitly filtered out.
The Maven selection was:
```sh
mvn -o -B -T 2 -gs <empty-settings.xml> -s <empty-settings.xml> \
clean verify -pl integration-test -am -Pwith-integration-tests,ClusterIT \
-Dtest=NoSuchSurefireTest -Dsurefire.failIfNoSpecifiedTests=false \
'-Dit.test=IoTDBLoadTsFileClusterIT#testRestartedDataNodeIsSyncedWithTheLoadedFile'
\
-DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false
```
The full test class and full test suites were not rerun in this review; the
earlier worker test was also not rerun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]