Caideyipi commented on PR #19025:
URL: https://github.com/apache/iotdb/pull/19025#issuecomment-6433434696

   Self-review passed after one follow-up fix. I reviewed the full PR diff and 
the relevant receiver, active-load, conversion, and authorization paths.
   
   - **[P1] Authorize tree-model tablet replay before execution** — 
[`LoadTsFileDataTypeConverter.java:272`](https://github.com/apache/iotdb/blob/7a69739f8714cdc49dc2f3d830b150ff126aaa8d/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTsFileDataTypeConverter.java#L272-L280).
 Restoring the session alone did not enforce `WRITE_DATA`: direct Coordinator 
execution relies on its caller to check permissions, and conversion can run 
before all Load validation has completed. Fixed in 
[73fa2cdc739](https://github.com/apache/iotdb/pull/19025/commits/73fa2cdc73911a05bd81bccd21ed821e96750fe4)
 by checking the effective user's permissions before dispatch and returning 
denial statuses unchanged. Added three regressions covering background 
identity, preservation of the current session, and missing identity in both 
dialects.
   
   Final validation of the updated source on Linux, OpenJDK 17.0.15, Maven 
3.9.12:
   
   - Clean DataNode reactor and 
`IoTDBDataNodeReceiverTest,ActiveLoadTsFileLoaderTest,LoadTsFileDataTypeConverterTest`:
 **29 tests passed**, 0 failures/errors/skips.
   - Clean integration-test reactor with 
`with-integration-tests,MultiClusterIT2DualTableManualBasic` and only 
`IoTDBPipeWithLoadIT#testAsyncLoadAutoCreateWithoutInsertPermission` selected: 
**1 test passed**, 0 failures/errors/skips. Confirmed the exact method and 
counts in the Failsafe XML report.
   - `mvn spotless:apply -P with-integration-tests` and `git diff --check`: 
passed.
   
   Required IoTDB modules and TsFile were rebuilt from clean source with Maven 
build caches disabled. The previously pending asynchronous IT assertions are 
now verified by the Linux run; the earlier Windows setup interruption did not 
validate them. No additional actionable issues were found in the PR diff.
   
   <!-- self-review:pr-19025:73fa2cdc73911a05bd81bccd21ed821e96750fe4 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to