Caideyipi commented on PR #19025:
URL: https://github.com/apache/iotdb/pull/19025#issuecomment-6433636366

   Re-review passed at 
[`73fa2cdc739`](https://github.com/apache/iotdb/commit/73fa2cdc73911a05bd81bccd21ed821e96750fe4).
 I inspected the complete diff (all 7 files) and the relevant receiver 
authentication, durable active-load attributes, tree/table conversion 
authorization, status propagation, and session cleanup paths. No new actionable 
findings were identified, so no additional branch changes or fixes were needed. 
The earlier tree-model authorization fix remains included.
   
   Validation status:
   
   - **This re-review:** `git diff --check` passed for the full PR diff; the 
reviewed checkout was clean. No builds or tests were rerun during this 
re-review because the source is unchanged.
   - **Previously reported remote validation of this same commit** ([existing 
self-review](https://github.com/apache/iotdb/pull/19025#issuecomment-6433434696)):
 the clean DataNode reactor with 
`IoTDBDataNodeReceiverTest,ActiveLoadTsFileLoaderTest,LoadTsFileDataTypeConverterTest`
 passed **29 tests**, with 0 failures/errors/skips. The clean integration-test 
reactor with `with-integration-tests,MultiClusterIT2DualTableManualBasic` 
passed `IoTDBPipeWithLoadIT#testAsyncLoadAutoCreateWithoutInsertPermission` 
(**1 test**, 0 failures/errors/skips).
   - **Local execution status:** the three methods in 
`LoadTsFileDataTypeConverterTest` and 
`IoTDBPipeWithLoadIT#testAsyncLoadAutoCreateWithoutInsertPermission` remain not 
run on the local Windows machine; all four have passed remotely. The remote 
results above are prior validation, not new executions in this re-review.
   
   <!-- re-review:pr-19025:73fa2cdc73911a05bd81bccd21ed821e96750fe4 -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to