Caideyipi commented on PR #19037:
URL: https://github.com/apache/iotdb/pull/19037#issuecomment-6465651286

   Re-review summary for the full PR diff against `master`, ending at 
`7cb198e4b52ee7265be4519b12d7c6f20adef657`.
   
   Found and fixed one test-isolation issue in the added metadata cluster 
reuse: `IoTDBDatabaseIT.testInformationSchema` creates a double-living pipe 
whose tree-model counterpart survived table-only cleanup. A subsequent 
`testDBAuth` could then fail because pipe `a2b` already existed. Cleanup now 
drops pipes through both table and tree SQL dialects, quotes identifiers for 
the corresponding dialect, and uses a bounded wait to confirm both pipe lists 
are empty before the next method. The original test methods and assertions are 
preserved.
   
   This update adds class-level cluster reuse to the table-model 
`IoTDBDatabaseIT` and `IoTDBDatabaseMaxRegionGroupNumIT`, and ConfigNode's 
`IoTDBDatabaseSetAndDeleteIT`, with per-method database/user/pipe cleanup as 
applicable. The relevant tree-model schema suites already reuse clusters per 
Memory/PBTree parameter.
   
   Verification:
   
   - Spotless apply and `git diff --check` passed. The required reactor 
dependencies and metadata IT sources compiled locally after rebuilding IoTDB 
and the corresponding TsFile dependency from clean source.
   - The earlier remote metadata run of the initial patch passed 13 methods and 
failed `testDBAuth` with the pipe-isolation issue above. It does not establish 
that the current fix passes.
   - The updated local `TableClusterIT` run did not complete: DataNode JVMs 
failed during class setup with Windows native-memory allocation error 1455. 
There is no passing result for the 14 intended methods at the current revision.
   - The `ClusterIT` attempt for ConfigNode's two methods was stopped before IT 
execution when available Windows commit memory fell to 319 MiB. These methods 
were not run.
   - A remote rerun was blocked by build-extension resolution. The existing 
remote results for other scopes are retained in the PR description with their 
tested revisions; they were not rerun for this update. No new test methods were 
added.
   
   The PR remains draft because this round found an issue affecting test logic. 
After the fixes and checks above, a fresh session must perform the next 
complete independent re-review; this round is not an issue-free approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to