Caideyipi commented on PR #19037: URL: https://github.com/apache/iotdb/pull/19037#issuecomment-6490477041
Single-round independent re-review completed at `f81c7b44c2d38ef916651a054377b1b908496b5f` against PR base `bf1ea20e2356734231a626ffa1c0a76373b59056`, covering the full 34-file diff and relevant context. No new actionable source-behavior or test-logic issues were found, and no code changes were needed. The four fixtures changed in `f81c7b44c2d` (`IoTDBLoadTsFileIT`, `IoTDBShowReceiversIT`, `IoTDBDatabaseIT`, and `IoTDBDatabaseMaxRegionGroupNumIT`) now use the shared database-cleanup helper correctly. The review checked both SQL dialects, preservation of `root.__audit` / `__audit`, identifier quoting, and the existing bounded table-database overlap retry against the fixtures' cleanup order and lifecycle. The earlier fixes in `8df231b051c`, `904b94a1fac`, and `ac51078cf24` were also revisited. Verification status: - `git diff --check` for the full current PR diff passed in this round. The recorded Spotless apply at this same `f81c7b44c2d` revision passed; this read-only re-review did not rerun Maven. - Current-revision ITs remain **not run**. The recorded local Maven attempt could not start because of JVM native-memory allocation failure. The recorded remote Maven 3.9.12 attempt could not resolve dependencies because Maven Central was unreachable. Those attempts neither compiled source nor executed tests; this round made no additional Maven/test attempt. - The subscription-enabled `SimpleIT` (10 tests) and `TableClusterIT` (2 tests) results at `ac51078cf24` are historical, revision- and edition-specific evidence only. No OSS subscription pass or current-revision subscription pass is claimed. - The newly added `PartialPathTest#testStartsWithOrEqual` and `ClusterTemplateManagerTest#testCheckTemplateSetInfo` remain unrun locally. The latest remote head still matches the reviewed commit. The PR remains **draft** because required current-revision validation is incomplete. No second review round was performed in this session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
