Caideyipi commented on PR #19043:
URL: https://github.com/apache/iotdb/pull/19043#issuecomment-6486265969

   Review round found a version-matching bug in 
`PipeDataNodeTaskAgent.handleMultiPipeMetaChanges`. The replacement cleanup set 
could treat a delayed `DROPPED` record for an older pipe generation as matching 
the current same-name pipe, then remove the current task during partial 
metadata cleanup. A `PRE_DELETE` record for a different generation could also 
enter cleanup. Fixed in `dea95b01548b73bacd8e243cf8946dcad8a0ce20`: resolve 
`DROPPED` by pipe name and creation time, and exclude `PRE_DELETE`; added 
regression tests `testPartialStaleDropDoesNotRemoveNewerPipe` and 
`testPartialPreDeleteDoesNotRemoveExistingPipe`.
   
   Validation: `mvn spotless:apply -P with-integration-tests -pl 
iotdb-core/datanode` and `git diff --check` passed. The new tests were not run: 
the remote attempt was blocked by GitHub TLS/Maven dependency download 
failures, and the local attempt exited on JVM native-memory allocation failure. 
The current GitHub check status could not be fetched because the GraphQL 
request timed out, so CI for this head is unverified.
   
   Because this round found and fixed a behavior issue, the PR remains draft 
pending an independent re-review of head 
`dea95b01548b73bacd8e243cf8946dcad8a0ce20`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to