Caideyipi commented on PR #19043: URL: https://github.com/apache/iotdb/pull/19043#issuecomment-6486517149
Completed one independent re-review of `dea95b01548b73bacd8e243cf8946dcad8a0ce20`, covering the full three-file diff from merge base `8cdc9681d0141fa51cfd0dc120b67a7383270865` (both PR commits), the subscription and alter callers, task/metadata reconciliation, schema queue cleanup, and the regression tests. No actionable source-behavior or test-logic issues were found; no fixes or branch updates were needed. The generation-specific `DROPPED` matching and `PRE_DELETE` exclusion address the previous round's findings. Validation: - `git diff --check origin/master...HEAD` passed. A merge-tree check against fetched `master` (`b1ea6b52ebd`) found no conflicts; that merged tree was not compiled or tested in this session. - Current-head Linux DataNode CI ran `PipeDataNodeTaskAgentTest` (17 tests) and `DataNodeInternalRPCServiceImplPushMultiPipeMetaTest` (9 tests): all 26 passed, with no failures, errors, or skips. This includes `testPartialStaleDropDoesNotRemoveNewerPipe` and `testPartialPreDeleteDoesNotRemoveExistingPipe`. The checkout log confirms merge `f98d45623c7c50a9c06b3c480e16b7fcd0e5505d`, merging this head into `8cdc9681d0141fa51cfd0dc120b67a7383270865`. [CI execution log](https://github.com/apache/iotdb/actions/runs/40802085266/job/123212303941). - No Maven build/tests or manual end-to-end consumer-close reproduction were rerun locally or on private hosts in this read-only round. CI supplies the execution evidence; the earlier local native-memory failure was not retried. - CI is not fully green: [Chinese-locale compilation](https://github.com/apache/iotdb/actions/runs/40802085372/job/123212303657) failed resolving distribution ZIP dependencies, so it cannot be reported as passed. [SonarCloud](https://github.com/apache/iotdb/runs/123215864898) still reports a failed quality gate; its BUG/VULNERABILITY entries are outside the changed files. The new method's null-return suggestion conflicts with the existing lock-timeout response contract. This round passes the independent-review gate. The remote head will be checked again before marking the PR ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
