Caideyipi commented on PR #19051:
URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6496093119

   I reviewed the P1 metadata recovery test additions in commit `c5ebc9b1c15d`. 
I found no concrete correctness issues in the covered scenarios; the partial 
items below are coverage gaps, not code defects.`n`n- P1-1: Partial — 
concurrent same/conflicting auto-creation and ConfigNode leader failover are 
checked; SchemaRegion leader failover is not covered.`n- P1-2: Partial — 
template extension, interrupted deactivation, and recovered results are 
checked, but the missed-broadcast DataNode is stopped and restarted, so 
recovery of a still-running node with stale cache is not covered.`n- P1-3: 
Covered — schema-log recovery checks tag/alias indexes, complete SHOW/count 
results, and follow-up reads and writes.`n- P1-4: Partial — database TTL 
inheritance, an overridden table TTL, expired-read filtering, and the 
recovered-node write boundary are checked; dynamic per-table or Tree 
parent/child TTL changes are not covered.`n- P1-5: Partial — Table 
tree-to-table auto-sync is checked af
 ter rename/replace/disable and node recovery; Tree logical-view recovery is 
not covered.`n- P1-6: Partial — a real SchemaRegion migration is verified with 
metadata changes and post-migration reads/writes; other migration/rebuild 
failure stages are not covered.`n- P1-7: Covered — quota exhaustion, failed 
activation, deletion/restart, bounded quota refresh, retry, and subsequent 
writes are checked.`n- P1-8: Covered — catalog snapshot, subsequent DDL, 
ConfigNode recovery and leadership transfer, catalog state, reads/writes, and 
continued DDL are checked.`n`nValidation: the IT-enabled reactor compilation 
passed across 37 modules in the source worktree. The Failsafe report confirms 
only `IoTDBSchemaLogRecoveryIT` executed (1 test passed, 0 failures); the other 
new ITs were not executed. The PR remains a draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to