Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6514884653
Metadata P0 review/fix round for `030e5c543f9efe3b378e6e01c77fde35a4b875bb`. This round found and fixed test-logic and fixture precondition issues: - Use supported equality predicates and complete device keys for cross-Region DELETE DEVICES; retain full metadata/data assertions and the unaffected-device checks. - Make snapshot installation real by reducing the SchemaRegion log purge gap only inside the test agent, checking actual log truncation and a newer installed snapshot, selecting an actual follower distinct from the SQL coordinator, and addressing leader-transfer RPCs to the intended new leader. - Give the PBTree fixture enough schema memory for its pinned Region roots; prepare template catalog extensions while all nodes are online; assert the alias query's actual column header. - Wait for all actual IoTConsensus DataRegion replicas before the DROP fixture's flush/stop. Recreate only after the exact `SUCCESS / written=1 / remaining=0` result while the stale DataNode remains offline. - Wait for a direct RPC response from the restarted ConfigNode before reusing the shared cluster. Final validation: Apache IoTDB on JDK 17, `ClusterIT` + `TableClusterIT`, 3 ConfigNodes/3 DataNodes. **17 tests passed, with 0 failures, 0 errors and 0 skips; Maven exited 0.** Tree ran in Memory/PBTree and Table in Memory. The Failsafe class XML reports confirm the counts. Spotless and `git diff --check` passed. Required IoTDB dependencies were built from clean source before the provenance-matched retries. The new P0 fault agent and controls stay under `integration-test/src/test`; no new production hook was added. Existing P1 production hooks are unchanged and remain a follow-up/full-PR review concern. The existing Pipe/P1 suites were not rerun in this round. This round does not approve the full PR. It remains a draft pending a fresh independent review of the latest complete diff and context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
