Caideyipi commented on PR #19056: URL: https://github.com/apache/iotdb/pull/19056#issuecomment-6514523544
Independent review of commit c98168f435544cf732a7fe6c721788cbc1320768 found one confirmed P2 issue and one test-logic issue. Confirmed P2 — full PipeMetaSync loses top-level DataNode failures: - `PipeMetaSyncProcedure.java:215-220` calls the overload `recordDataNodePushPipeMetaExceptions(respMap)` without a fallback pipe. - A top-level exception in `DataNodeInternalRPCServiceImpl.pushPipeMeta` (`:1395-1398`) returns `PIPE_PUSH_META_ERROR` without `exceptionMessages` or a status message. - `PipeTaskInfo.java:1173-1191` sets `hasException` but, with no fallback, continues without recording STOPPED, `isStoppedByRuntimeException`, or a node exception. As a result, a full metadata sync can keep retrying while SHOW PIPES still reports RUNNING and an empty ExceptionMessage, and the failure is not persisted for automatic restart/recovery. The full-sync path needs an attribution/fallback strategy for responses that cannot identify a pipe, plus coverage for the empty-details and retry/persistence cases. Confirmed test-logic issue (fixed): `IoTDBPipeAutoSplitIT` supplied `user=root` for the write-back sink but omitted `password`, which caused CI error 701. Commit `e759aab86b3b9a7e3c0eb5f82199c28a7fd987ba` adds `password=root`. The targeted `IoTDBPipeAutoSplitIT` run completed 2/2 tests with `BUILD SUCCESS`; the PR remains draft. Remaining test gap: `PipeMetaSyncProcedureTest` covers a named exception message, but does not cover the top-level `PIPE_PUSH_META_ERROR` response with no `exceptionMessages`, which is the confirmed failure path above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
