Caideyipi commented on PR #19056:
URL: https://github.com/apache/iotdb/pull/19056#issuecomment-6517078828

   Independent re-review of PR #19056 at 
`e759aab86b3b9a7e3c0eb5f82199c28a7fd987ba` found two actionable P2 behaviors, 
both fixed in `31d9b949d2947f09fca8ab0cf7346e7ac330f2f8`:
   
   - A full metadata sync receiving `PIPE_PUSH_META_ERROR` without exception 
details did not assign the failure to any pipe, so `STOPPED`, the 
runtime-exception stop flag, the DataNode exception message, and consensus 
persistence were missing. The unscoped response is now applied to all pipes 
during full sync.
   - If a DataNode push failure was recorded in memory but its consensus write 
failed, a retry that then received a successful push could finish without 
persisting the earlier failure. The retry path now flushes pending pipe-meta 
exceptions before pushing again, including Create, Alter, Start, and full-sync 
procedures.
   
   Regression coverage was added for full-sync unscoped errors and persistence 
retries in full-sync, Create, and Start. Verification: the focused remote Maven 
reactor completed with `BUILD SUCCESS`; Surefire reports 36 tests, 0 
failures/errors/skips, including PipeMetaSync, Create, Start, Abstract 
procedure, and auto-restart tests. `git diff --check` is clean. The PR remains 
OPEN/DRAFT as requested.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to