Caideyipi commented on PR #19071:
URL: https://github.com/apache/iotdb/pull/19071#issuecomment-6570601990
Initial self-review completed for `4c4c9eed08624ad0f071ec52961bd3a18845f33b`.
- **P2, fixed:** `PipeTemporaryMetaInCoordinatorMetrics` used
`pipeID.split("_")` and only the first two fields for both global
remaining-event/time gauge tags. Names such as `pipe_with_underscores` were
truncated, and different names or creation times could share gauges;
deregistering one pipe could remove another's gauges. Creation/rebinding and
removal now split at the final underscore.
- Added a regression covering exact tags and live values, four independent
identities including leading/trailing underscores, metric-service restarts, and
selective deregistration. The original implementation fails with expected 4
gauges versus actual 2; all 5 tests in `PipeConfigNodeMetricsRestartTest` pass
after the fixes, with none skipped.
- Rebuilt the required dependency closure from clean source with build
caches disabled. Spotless apply and `git diff --check` passed. Verification ran
on a separate build machine; a full repository build and a second locale build
were not needed for this same-module change without API or message changes.
- The existing SonarCloud `java:S3078` warning in the unchanged
`PipeTaskInfo.java:1165` is outside this patch and was left unchanged; its
impact needs separate assessment.
Final local commit, confirmed source-branch head, and confirmed PR head:
`6f952119ffd0abc0ed55125978d665a067fd8ef0`. The update is fully pushed. CI for
the updated head is separate from the verification above. This behavioral fix
requires a fresh independent review, so the PR remains Draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]