Caideyipi commented on PR #19071: URL: https://github.com/apache/iotdb/pull/19071#issuecomment-6570673452
Independent re-review passed for `6f952119ffd0abc0ed55125978d665a067fd8ef0`. No actionable findings were identified, and no fixes were needed. - Inspected the complete three-file diff against `master`, including both earlier fixes, and followed the ConfigRegion runtime task-ID construction, registration/lookup and heartbeat call sites, global gauge creation/rebinding/removal, and regression assertions and cleanup. - Refreshed target tip: `999721fcafd5e95ff5f3de931ad34175ea315946`; merge base: `574aa691f0e68f769f26440f8c2ce9b05652f141`. The target-only commit does not change the reviewed metrics paths. - Reused the recorded clean-source, cache-disabled remote validation: all 5 tests in `PipeConfigNodeMetricsRestartTest` passed, and the underscore regression failed on the previous implementation. Current production/test hashes match that verified snapshot. Spotless apply and diff checks were already successful; no builds or tests were rerun in this read-only round. Reviewed SHA, final local SHA, confirmed source-branch SHA, and confirmed PR head are all `6f952119ffd0abc0ed55125978d665a067fd8ef0`. No commits or push were needed, and no update step remains incomplete. The PR is now ready for review. CI remains in progress and is separate from this review result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
