Caideyipi commented on PR #19102: URL: https://github.com/apache/iotdb/pull/19102#issuecomment-6595574599
## Initial independent self-review Reviewed the full diff against `origin/master` and the relevant connection, Thrift, message, and test context at `54dc422a67461690d7ceb1a7425a4891e3cc0485` (base: `e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`). The original legacy-diagnostic fix is correct. The requested similar-issue inspection found related pre-existing behavior problems, which are included in this round's fixes. Findings fixed: 1. **P2 — Password-expiration recognition depends on the driver locale** ([source](https://github.com/apache/iotdb/blob/54dc422a67461690d7ceb1a7425a4891e3cc0485/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java#L608)). An English warning is missed by a Chinese driver, and the existing Chinese prefix is missed by an English driver. Recognition now accepts both supported prefixes, while the emitted warning remains localized. 2. **P2 — Absent session messages cause NullPointerException** ([status-message path](https://github.com/apache/iotdb/blob/54dc422a67461690d7ceb1a7425a4891e3cc0485/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java#L610), [exception path](https://github.com/apache/iotdb/blob/54dc422a67461690d7ceb1a7425a4891e3cc0485/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java#L625)). Missing optional status text no longer breaks a successful session. Message-less transport errors retain the normal SQLException wrapper, original cause, and transport cleanup. 3. **P3 — The added test helper fails Spotless** ([source](https://github.com/apache/iotdb/blob/54dc422a67461690d7ceb1a7425a4891e3cc0485/iotdb-client/jdbc/src/test/java/org/apache/iotdb/jdbc/IoTDBConnectionTest.java#L205)). The initial CI logs stop at this formatting violation. The helper has been formatted, and both final reactor runs passed formatting checks. Verification: - Before the behavior fixes, four targeted tests in a clean Chinese-locale JDBC reactor run produced the expected two failures and one error, reproducing the missed warning and both null-message failures. - Default-locale JDBC unit tests: **132 passed**, zero failures/errors/skips. - Chinese-locale `IoTDBConnectionTest`: **17 passed**, zero failures/errors/skips. - Both final runs rebuilt the required reactor dependencies from clean sources with build caching disabled; all 115 goals executed in each run. Maven exited 0 in both runs. - Spotless apply passed for both changed Java files. All newly added tests were run locally. - CI for the updated commit is still queued/in progress; it is not reported as passed. No live legacy-server integration test was run. Final local SHA, confirmed remote branch SHA, and confirmed PR head SHA: **`6d25d48e081484c4c2d2454e672e667df4623541`**. The fixes are committed and pushed; no update step remains incomplete. The PR remains **Draft** as requested. This round included behavior changes and requires an independent re-review in a fresh session. No second review round was run in this session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
