Caideyipi commented on PR #19102:
URL: https://github.com/apache/iotdb/pull/19102#issuecomment-6596909585

   ## Independent re-review
   
   Reviewed the full PR diff against `origin/master` at base 
`e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`, including the prior fixes, at 
reviewed commit `6d25d48e081484c4c2d2454e672e667df4623541`. The 
locale-independent password-expiration matching and absent-message handling 
remain correct.
   
   One build issue was fixed: the JDBC tests use `ListAppender` from 
`logback-core`, but the POM declared only `logback-classic` directly. Added a 
test-scoped `logback-core` dependency in commit 
`878416cdc77a89d4342f8c6384d0d87c901cec77`. No source behavior or test-logic 
changes were needed.
   
   Verification:
   
   - Clean JDBC reactor `test-compile` and `dependency:analyze-only` passed; 
all 118 goals completed and the JDBC dependency analyzer found no problems.
   - The unchanged Java source had already passed 132 default-locale JDBC tests 
and 17 Chinese `IoTDBConnectionTest` tests; all newly added tests were run 
locally. Those tests were not repeated because this update only changes the 
test dependency declaration.
   - The Linux and Windows `unit-test (..., others)` checks failed on the 
reviewed SHA at dependency analysis for this missing direct dependency. Other 
checks on that SHA also failed and were not analyzed in this round; checks for 
the final SHA are in progress, so no overall CI result is claimed.
   - No live legacy-server integration test was run.
   
   Reviewed SHA: `6d25d48e081484c4c2d2454e672e667df4623541`. Final local, 
remote branch, and PR HEAD SHA: `878416cdc77a89d4342f8c6384d0d87c901cec77`.
   
   The PR remains Draft as requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to