ColinLeeo commented on PR #19035:
URL: https://github.com/apache/iotdb/pull/19035#issuecomment-6625713053

   Reworked the scope after the review discussion — the description is updated.
   
   - The sort now lives in 
`TableInsertTabletStatementGenerator#constructInsertTabletStatement()` and 
covers **only the table-model `INSERT INTO ... SELECT` path**; it orders the 
rows by time before the statement leaves the INTO path.
   - The coordinator-wide reordering, the device-grouping sort and the pipe 
changes it required are gone. Those touched row order in places other ingresses 
depend on (redirect endpoints, attributes, the pipe time filter), which is more 
than this bug needs.
   - Device attributes keep the submitted order through the permutation the 
sort records, so "last non-null value of the client row wins" is unchanged.
   - The diff is now 21 files, mostly the sorter move plus the generator change 
and its tests.
   
   The tree-model INTO path, REST, MQTT and the session API are explicitly out 
of scope: they still rely on the documented contract that the client submits an 
ordered batch. If we want to cover them later, the same sort can be invoked at 
their entry points.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to