Caideyipi commented on PR #19035: URL: https://github.com/apache/iotdb/pull/19035#issuecomment-6621742023
Reviewed commit `8f31c0911af96cb635edf231f2d45795b8898da0` against the PR merge base `ca8074d15c824f2533d357778e40f773d02b5565` (23 changed files). I do not recommend merging this revision yet. The following existing comments remain applicable after tracing the affected call paths: - [Shared Pipe source arrays](https://github.com/apache/iotdb/pull/19035#discussion_r4462672895): table sorting replaces the statement's timestamps but mutates the source node's shared column/bitmap containers, which can leave timestamp/value pairs inconsistent for another consumer. - [Session redirect ordering](https://github.com/apache/iotdb/pull/19035#discussion_r4462672866): redirect endpoints are generated in the server's reordered row order, while the client associates them with devices in the original request order. - [Attribute update ordering](https://github.com/apache/iotdb/pull/19035#discussion_r4462672946): sorting before device-schema validation changes which input row supplies the last non-null attribute value for a device. - [SQL regression page layout](https://github.com/apache/iotdb/pull/19035#discussion_r4462672919): the test setup still does not configure the multi-page layout that its reproduction requires. No additional distinct actionable findings were confirmed in this review, so I have not duplicated the existing inline comments. Validation: static review of the complete PR diff and relevant callers, schema-validation paths, sorters, and tests. No build, unit tests, or integration tests were run in this review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
