Caideyipi commented on PR #19110:
URL: https://github.com/apache/iotdb/pull/19110#issuecomment-6647179270

   Initial independent self-review completed for PR #19110 at reviewed head 
`d6a8447b0872755be8c6c761dc7069b5c6381680`. The review covered the full diff 
against master and the relevant DEFAULT parsing, no-op, snapshot, persistence, 
rollback, concurrent database TTL, and Pipe test context.
   
   Two behavioral issues were confirmed and fixed in 
`295c34f43ae91eb2ede40f4a43970898547b3f8f`:
   
   - [Default 
resolution](https://github.com/apache/iotdb/blob/295c34f43ae91eb2ede40f4a43970898547b3f8f/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java#L2000):
 an unset or infinite database default could remain `null` until persistence. A 
concurrent database TTL change could then make persisted metadata differ from 
the DataNode pre-release snapshot. The validated plan now captures `INF`, and 
no-op handling compares the effective infinite TTL.
   - 
[Rollback](https://github.com/apache/iotdb/blob/295c34f43ae91eb2ede40f4a43970898547b3f8f/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/schema/table/SetTablePropertiesProcedure.java#L74):
 restoring an absent original TTL through `null` could adopt a later database 
default. Rollback now explicitly restores `INF`. Regression coverage includes a 
failed property write, procedure recovery, and a concurrent database-default 
change.
   
   The Pipe test's one-day database TTL retains its finite metadata assertions 
and prevents queued implicit-timestamp writes from expiring under the corrected 
DEFAULT behavior; no further change was needed there.
   
   Directed validation of the repair candidate passed locally: Spotless, the 
two ConfigNode unit classes (15 tests), the focused rollback regression, and 
`IoTDBTableIT#testResetTableTtlUsesDatabaseDefault` in TableClusterIT (1C3D). 
No failures, errors, or skips were reported. The prior remote checks on 
`d6a8447b` also passed the table IT in 1C3D and 1C1D and the Pipe 
`testTableSync`; those are earlier results, not new directed runs on the repair 
commit.
   
   Full GitHub CI is separate: on the final commit, 42 checks report 40 
successful, 1 failed (`SonarCloud Code Analysis`, Reliability Rating C), and 1 
cancelled (a Windows IT shard). The two Sonar reliability alerts are in 
`PipeTaskInfo.java` and `PipeResourceMetrics.java`, both unchanged by this PR, 
and remain for separate triage. Full CI is not reported as passing.
   
   Final local commit, confirmed source-branch head, and PR head: 
`295c34f43ae91eb2ede40f4a43970898547b3f8f`. The PR remains Draft because this 
round found behavioral issues. A fresh independent review of the updated full 
diff is required before marking it ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to