Caideyipi commented on PR #19110: URL: https://github.com/apache/iotdb/pull/19110#issuecomment-6647443973
Independent re-review (round 2) at reviewed head `295c34f43ae91eb2ede40f4a43970898547b3f8f` against refreshed `master` `03a28bace3589ff5d9d45c0f20c7a5686b6d8dab` (merge base `2fd7d838cbab3bd8645681b8020c5597e340378d`) found no actionable findings. I reviewed the complete six-file diff, including the prior behavior fixes, and traced DEFAULT TTL resolution, no-op cases, unset and infinite defaults, table snapshot isolation before pre-release, persistence after database TTL changes, rollback after failed writes, and the Pipe table metadata synchronization test adjustment. No changes were needed in this round. The final local commit and confirmed source branch/PR head are both `295c34f43ae91eb2ede40f4a43970898547b3f8f`. The existing local verification record for this head reports that all added tests and the directed ConfigNode and Table IT checks passed. In this round, `git diff --check origin/master...HEAD` passed. The IT-selection script could not complete in this Windows environment because its Bash shard helper failed and temporary-directory cleanup was denied. Remote CI is separate from directed validation: 40 checks succeeded, `SonarCloud Code Analysis` failed, and one Windows test shard was cancelled. The PR is now ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
