Caideyipi commented on PR #19133: URL: https://github.com/apache/iotdb/pull/19133#issuecomment-6652699588
## Initial independent self-review Reviewed revision: `73c38310ade9436b85576c201486c4945d5175bd`. One P2 behavioral issue was found and fixed: - [TableDeviceSchemaFetcher.java:418](https://github.com/apache/iotdb/blob/73c38310ade9436b85576c201486c4945d5175bd/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java#L418): StringValueFilterVisitor returns a nullable Boolean for comparison, IN, and LIKE predicates on NULL. Passing that result through Predicate<AlignedDeviceEntry> implicitly unboxed it and failed the query instead of treating SQL UNKNOWN as a non-match. The final boundary now uses `Boolean.TRUE.equals(...)`. Expanded the existing recovery cases with NULL comparison, IN/NOT IN, LIKE/NOT LIKE, and OR assertions for COUNT DEVICES and SELECT on every DataNode. Removed the redundant direct ASM runtime declaration from the integration-test POM; DataNode already supplies it transitively. Validation: - A clean build of the required 37-module source dependency closure followed by the expanded tests reproduced the failure on the initial PR revision: all 3 cases failed with the nullable-Boolean unboxing error, with 0 skipped. - After cleaning and rebuilding the changed DataNode and integration-test modules, all 3 cases passed: 0 failures, 0 errors, and 0 skipped. Compilation, Spotless, Checkstyle, and forbidden-API checks passed. - Verification ran on Windows with JDK 17, using 1 ConfigNode and 2 DataNodes. Agent compilation and child-JVM startup succeeded without the removed direct dependency. All newly added integration tests were run locally. - Linux verification did not reach tests because dependency/plugin resolution was blocked. The full project unit-test suite was not run. - Remote CI was queued or running at the last observation; this review did not wait for it. Fix commit: `71fa1ebed96dc78e4b37aba1e651ee09aa70342d` (`Handle unknown cached attribute predicates`). Final local SHA and confirmed source-branch/PR-head SHA: `71fa1ebed96dc78e4b37aba1e651ee09aa70342d`. No branch-update step remains incomplete. This round found a behavioral issue, so the completed repair and passing tests do not satisfy the independent zero-issue review gate. The PR remains draft pending a fresh independent re-review of the full latest diff and relevant context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
