Caideyipi commented on PR #19133:
URL: https://github.com/apache/iotdb/pull/19133#issuecomment-6653030668

   ## Independent re-review
   
   Reviewed revision: `71fa1ebed96dc78e4b37aba1e651ee09aa70342d` against the 
current `apache/master` (`4b80fa56a999baf9de625f10b392bf2f2bcaa880`). The PR 
API still reports base `e92ecf1d5d62de0c67a52e80ff6cb7e307ab6583`; the two 
intervening master commits touch unrelated subscription files.
   
   No actionable source-behavior or test-logic findings were found, and no code 
changes were needed. The reviewed final diff includes the nullable 
cached-attribute handling and expanded regression assertions. The commit 
history confirms the temporary direct ASM dependency was removed, leaving no 
net POM change.
   
   Validation: the three added integration tests passed on Windows with JDK 17 
in the prior verification. This read-only round did not rerun tests. Linux 
dependency/plugin resolution did not reach test execution, and the full 
unit-test suite was not run. Remote CI was not polled.
   
   Final local SHA: `71fa1ebed96dc78e4b37aba1e651ee09aa70342d`.
   Confirmed source-branch and PR-head SHA: 
`71fa1ebed96dc78e4b37aba1e651ee09aa70342d`.
   PR status: Ready for review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to