Caideyipi commented on PR #19128:
URL: https://github.com/apache/iotdb/pull/19128#issuecomment-6675841620

   @luoluoyuyu, addressed the [database-policy 
comment](https://github.com/apache/iotdb/pull/19128#issuecomment-6656301118) in 
[0de7dcb04b1](https://github.com/apache/iotdb/commit/0de7dcb04b1cb68a4f7029cb24e5369b988e4b4f).
   
   - Both analyzer constructors now compute the effective global && request && 
session policy. Native tree/table schema validation and asynchronous handoff 
use it.
   - Tree LOAD checks existing databases before rejecting a missing database 
under the disabled policy. Table LOAD checks the same policy before CREATE 
DATABASE. Existing databases remain usable, and the active loader's default 
database-creation flag cannot override a disabled request policy.
   - Added a localized missing-database error and a specific exception that 
bypasses tablet conversion, preserving that error instead of replacing it with 
a conversion failure.
   - Added four regressions for request/session/global restrictions and error 
preservation. The database tests keep database creation enabled and verify that 
neither the database executor nor Coordinator performs a write. Existing table 
tests now exercise the database path, and async tests include the global switch.
   
   Verification:
   
   - Clean 28-module source-reactor compilation of production and test sources 
passed for both English and Chinese locales, with build-cache reuse disabled, 
using JDK 17.0.15 and Maven 3.8.8.
   - The English run passed 53 of 54 selected methods, including all four new 
regressions. One existing fixture disabled verification while still expecting a 
schema read; it now verifies matching existing schema. Only that failed method 
was rerun in the clean Chinese-locale reactor and passed. Latest results across 
all 54 unique selected methods in five classes: 54 passed, 0 
failures/errors/skips.
   - Final Spotless apply with the integration-test profile, Checkstyle, 
English forbidden-API checks, and the diff whitespace check passed. Duplicate 
Spotless/forbidden-API checks were skipped in the Chinese run.
   - RAT was skipped. Used the published TsFile dependency 
2.5.1-261023-20261023.065606-1 without rebuilding it. The full suite and 
integration tests were not rerun.
   - New-head CI was queued/running at one snapshot and was not awaited.
   
   For the [Codecov 
report](https://github.com/apache/iotdb/pull/19128#issuecomment-6648442336), 
this update adds targeted missing-database and conversion-error coverage. The 
report predates this follow-up; no updated coverage percentage is claimed here.
   
   - Reviewed SHA (comment scope): bbe9ae485c8000327e137ec8aabf0be718149970
   - Final local SHA: 0de7dcb04b1cb68a4f7029cb24e5369b988e4b4f
   - Confirmed source-branch and PR-head SHA: 
0de7dcb04b1cb68a4f7029cb24e5369b988e4b4f
   
   The fixes are committed and pushed. Independent re-review of the full 
updated PR remains pending. The PR remains open and non-draft, and discussions 
have been left unresolved.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to