Caideyipi commented on PR #19128:
URL: https://github.com/apache/iotdb/pull/19128#issuecomment-6654053213

   Initial independent self-review — tree LOAD only. Table behavior was 
excluded as requested.
   
   Reviewed SHA: `0c083585227d8fcb91042a9c85d36e42687820bc`
   Final local SHA: `5e846cf7f2948acf024c9c5256d634c8dc3b37e1`
   Confirmed source-branch and PR-head SHA: 
`5e846cf7f2948acf024c9c5256d634c8dc3b37e1`
   
   **P2 — Native tree LOAD could ignore a disabled session auto-create policy 
(fixed).** With global and LOAD auto-creation enabled, a session disabling 
auto-creation could still reach schema creation. The per-file dialect switch 
rebuilt `SessionInfo` with the flag defaulting to true, and the list-schema 
validation path did not apply the effective policy guard. The fix [preserves 
the session flag and client 
version](https://github.com/apache/iotdb/blob/5e846cf7f2948acf024c9c5256d634c8dc3b37e1/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileAnalyzer.java#L497)
 and [guards list-schema 
auto-creation](https://github.com/apache/iotdb/blob/5e846cf7f2948acf024c9c5256d634c8dc3b37e1/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/SchemaValidator.java#L198).
 A real-TsFile regression runs the complete analysis entry point, verifies 
read-only schema fetching, forbids the auto-create fetcher, and checks every sw
 itched session retains the disabled flag.
   
   No other actionable findings were identified in the scoped tree review. This 
was one review round; the repaired commit has not received a second independent 
review in this session.
   
   Verification:
   
   - Clean 28-module source-reactor compilation with build-cache reuse 
disabled; JDK 17.0.15 and Maven 3.8.8. Five focused tree-policy methods passed. 
The initial new regression fixture stopped before the final schema-cache flush 
and failed; after correcting the fixture, only that method was rerun and 
passed. Latest results across the six unique selected methods: 6 passed, 0 
failures/errors/skips.
   - Checkstyle, Spotless, and the final diff whitespace check passed. A 
published timestamped TsFile dependency (`2.5.1-261023-20261023.065606-1`) was 
used rather than rebuilt.
   - Verification completed locally after remote setup/dependency-resolution 
attempts were stopped. RAT was skipped; the full test suite, integration tests, 
and the zh-locale build were not rerun.
   - New-head CI was queued/running at a single snapshot and was not awaited.
   
   The fix is committed and pushed, and both remote heads were confirmed. The 
PR remains **draft** because this round found a behavioral issue; a fresh 
independent tree-only review of the full current tree diff and relevant context 
is required before marking it ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to