JackieTien97 commented on code in PR #19125:
URL: https://github.com/apache/iotdb/pull/19125#discussion_r4510373803


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java:
##########
@@ -226,6 +226,88 @@ public BasicOpenSessionResp login(
     return openSessionResp;
   }
 
+  /**
+   * Opens a session without password verification for trusted internal client 
RPC callers.
+   *
+   * <p>This path is reachable only through the multiplexed client RPC service 
on the DataNode
+   * internal endpoint, which belongs to the trusted cluster/inter-node 
surface described in {@code
+   * THREAT_MODEL.md}. It intentionally does not emit failed-login audit 
records because it performs

Review Comment:
   Passwordless login is the intended design here, so no switch is needed, but 
THREAT_MODEL.md doesn't describe it yet, even though this Javadoc points to it. 
Please update it in this PR:
   
   - The §4 table lists `dn_internal_port` only as "DataNode internal RPC". It 
should also say that the port serves client sessions through the 
`IClientRPCService:` service prefix, and that anyone who can reach it can open 
a session as any existing user, including `root`, without a password.
   - §4 and §5a say the internal channels have no transport encryption today, 
while the Javadoc on `InternalClientRPCServiceProcessor` tells deployments to 
enable internal SSL. The document and the Javadoc should agree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to