shuwenwei commented on PR #19125:
URL: https://github.com/apache/iotdb/pull/19125#issuecomment-6734958504
Thanks for the second pass.
Addressed in `5502ab5f5a`:
- Internal passwordless login no longer writes any login audit record. The
Javadoc now states this explicitly.
- Updated `THREAT_MODEL.md` to document the client session surface on
`dn_internal_port`, including passwordless login for existing users, the
trusted-network requirement, and the fact that `enable_internal_ssl` is
optional and disabled by default. References to internal TLS were also made
consistent across the trust-boundary and configuration sections.
- Replaced the processor-wiring unit test with real behavior coverage:
- `InternalSessionIT` now uses a real DataNode internal endpoint for both
an unprefixed `IDataNodeRPCService` call and a multiplexed internal client
session.
- Added an internal login rejection case for a nonexistent user.
- `InternalSubscriptionTableIT` now runs with internal SSL enabled and
configures SSL on both the subscription-management session and pull consumer,
so the provider handshake and multi-DataNode poll path are exercised end to end.
- Removed `DataNodeInternalRPCServiceTest`, since it only tested a locally
constructed `TMultiplexedProcessor` and did not cover production wiring.
- Did not restore field-copy/config-wiring unit tests that require extra
production test seams.
One current CI failure is from the latest `master`:
`WALNodeTest.testDeleteOutdatedFiles()` still iterates `walFlushListeners`
after that variable/collection was removed upstream. This is independent of the
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]