Caideyipi commented on PR #19219:
URL: https://github.com/apache/iotdb/pull/19219#issuecomment-6791650662

   Follow-up review summary for `aeb1685cd9a726da486a640ee440209e7aa13d42`:
   
   - **Finding:** An ordinary retry heartbeat could be coalesced when a 
completion barrier was the last queued item, both in the realtime source 
pending queue and in the default realtime-first sink queue. This could leave a 
failed in-flight transfer without a heartbeat reaching the sink to trigger 
another attempt.
   - **Fix:** Retain the first ordinary heartbeat after a completion barrier in 
each queue, then continue coalescing subsequent ordinary heartbeats. Added 
sink-queue coverage and strengthened the source regression assertions.
   - **Validation:** The 28-module reactor succeeded; `PipeRealtimeExtractTest` 
(20 tests) and `PipeEventCollectorTest` (3 tests) passed, 23 total. Spotless 
and `git diff --check` passed.
   - **Not run:** Receiver DataNode restart cluster integration testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to