Caideyipi commented on PR #19219:
URL: https://github.com/apache/iotdb/pull/19219#issuecomment-6792459804

   Independent re-review at PR head `aeb1685cd9a726da486a640ee440209e7aa13d42` 
against current `origin/master` `6e7448d9bebd644259b695dfc8774d3d9f91252e` 
found no actionable behavior or test-logic issues; no code changes were needed. 
The source pending queue and default realtime-first sink queue retain one 
ordinary heartbeat after a completion barrier and coalesce subsequent ordinary 
heartbeats, while the downgraded TsFile source leaves barriers in place and 
preserves TsFile order; the regression assertions confirm heartbeat commits do 
not advance progress or complete the barrier before TsFile commits. 
Verification: the prior remote 28-module reactor succeeded and 23 focused tests 
passed (20 `PipeRealtimeExtractTest`, 3 `PipeEventCollectorTest`); Spotless and 
`git diff --check` passed. The sink-queue regression was not run locally, and 
the receiver restart cluster IT was not run. The first remote attempt failed 
during Maven Central dependency resolution; the later focused test run su
 cceeded. Reviewed, final local, and confirmed remote head: 
`aeb1685cd9a726da486a640ee440209e7aa13d42`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to