jt2594838 commented on code in PR #19242:
URL: https://github.com/apache/iotdb/pull/19242#discussion_r4548761717
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionIT.java:
##########
@@ -194,13 +227,14 @@ public void testInsertRecord() {
}
}
+ // Text-form records are parsed into DATE, TIMESTAMP, BLOB, and STRING
values.
Review Comment:
Scenario: Text-form records are parsed into DATE, TIMESTAMP, BLOB, and
STRING values.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1052 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionIT.java:
##########
@@ -126,13 +157,14 @@ public void testInsertByStrAndSelectFailedData() {
}
}
+ // DATE, TIMESTAMP, BLOB, and STRING values round-trip through typed record
insertion.
Review Comment:
Scenario: DATE, TIMESTAMP, BLOB, and STRING values round-trip through typed
record insertion.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1051 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -64,25 +65,48 @@
@RunWith(IoTDBTestRunner.class)
@Category(ClusterIT.class)
public class SessionSeedNodeFallbackIT {
+ private static final int DATA_NODE_COUNT = 3;
private static final int RECOVERY_CONNECTION_TIMEOUT_MS = 30_000;
- @Before
- public void setUp() {
+ @BeforeClass
Review Comment:
Prepare the scenario's configuration/state before execution. Compatible
classes retain class-owned nodes; protocol/topology matrix cases retain their
required separate lifecycle and bounded region budget.
<!-- it-runtime-rationale:c56099e483731cfb:1056 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionIT.java:
##########
@@ -342,13 +379,14 @@ public void testInsertTablet() {
}
}
+ // Session operations before open and after close consistently report a
closed session.
Review Comment:
Scenario: Session operations before open and after close consistently report
a closed session.
Reuse the scenario-owned Session for repeated writes/flushes, with closure
before cluster reset or restart so recovery uses fresh clients.
<!-- it-runtime-rationale:c56099e483731cfb:1054 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionIT.java:
##########
@@ -263,11 +298,12 @@ public void testInsertStrRecord() {
}
}
+ // Tablet insertion preserves typed values across both populated batches.
Review Comment:
Scenario: Tablet insertion preserves typed values across both populated
batches.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1053 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -37,8 +37,9 @@
import org.apache.iotdb.session.pool.SessionPool;
import org.awaitility.Awaitility;
-import org.junit.After;
+import org.junit.AfterClass;
Review Comment:
Retain the existing scenario lifecycle while adding the supporting
imports/state for the bounded polling, Session reuse or diagnostics changes in
this class.
<!-- it-runtime-rationale:c56099e483731cfb:1055 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -64,25 +65,48 @@
@RunWith(IoTDBTestRunner.class)
@Category(ClusterIT.class)
public class SessionSeedNodeFallbackIT {
+ private static final int DATA_NODE_COUNT = 3;
private static final int RECOVERY_CONNECTION_TIMEOUT_MS = 30_000;
- @Before
- public void setUp() {
+ @BeforeClass
+ public static void setUp() {
EnvFactory.getEnv()
.getConfig()
.getCommonConfig()
.setSchemaReplicationFactor(3)
.setDataReplicationFactor(3)
.setSchemaRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS)
.setDataRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS);
- EnvFactory.getEnv().initClusterEnvironment(1, 3);
+ EnvFactory.getEnv().initClusterEnvironment(1, DATA_NODE_COUNT);
+ }
+
+ @Before
+ public void restoreDataNodes() {
+ // The omitted-seed case leaves a node stopped. Restore it without
restarting healthy nodes,
+ // including when the previous case failed during its rolling restart.
+ List<Integer> restartedNodes = new ArrayList<>();
+ for (int index = 0; index < DATA_NODE_COUNT; index++) {
+ if (!EnvFactory.getEnv().getDataNodeWrapper(index).isAlive()) {
+ EnvFactory.getEnv().startDataNode(index);
+ restartedNodes.add(index);
+ }
+ }
+ for (int index = 0; index < DATA_NODE_COUNT; index++) {
+ awaitStatus(index, NodeStatus.Running);
+ }
+ // A Running heartbeat does not prove that a restarted node can serve the
next case's clients.
+ for (int index : restartedNodes) {
+ awaitLogin(index);
+ }
}
- @After
- public void tearDown() {
+ @AfterClass
Review Comment:
Destroy the class-owned cluster after all compatible scenarios finish, so
individual methods avoid repeated process startup/teardown.
<!-- it-runtime-rationale:c56099e483731cfb:1058 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -64,25 +65,48 @@
@RunWith(IoTDBTestRunner.class)
@Category(ClusterIT.class)
public class SessionSeedNodeFallbackIT {
+ private static final int DATA_NODE_COUNT = 3;
private static final int RECOVERY_CONNECTION_TIMEOUT_MS = 30_000;
- @Before
- public void setUp() {
+ @BeforeClass
+ public static void setUp() {
EnvFactory.getEnv()
.getConfig()
.getCommonConfig()
.setSchemaReplicationFactor(3)
.setDataReplicationFactor(3)
.setSchemaRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS)
.setDataRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS);
- EnvFactory.getEnv().initClusterEnvironment(1, 3);
+ EnvFactory.getEnv().initClusterEnvironment(1, DATA_NODE_COUNT);
+ }
+
+ @Before
Review Comment:
Restore only stopped nodes before the next seed-fallback scenario. Require
both Running status and login readiness for restarted nodes, preserving the
failover cases without restarting healthy processes.
<!-- it-runtime-rationale:c56099e483731cfb:1057 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -64,25 +65,48 @@
@RunWith(IoTDBTestRunner.class)
@Category(ClusterIT.class)
public class SessionSeedNodeFallbackIT {
+ private static final int DATA_NODE_COUNT = 3;
private static final int RECOVERY_CONNECTION_TIMEOUT_MS = 30_000;
- @Before
- public void setUp() {
+ @BeforeClass
+ public static void setUp() {
EnvFactory.getEnv()
.getConfig()
.getCommonConfig()
.setSchemaReplicationFactor(3)
.setDataReplicationFactor(3)
.setSchemaRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS)
.setDataRegionConsensusProtocolClass(ConsensusFactory.RATIS_CONSENSUS);
- EnvFactory.getEnv().initClusterEnvironment(1, 3);
+ EnvFactory.getEnv().initClusterEnvironment(1, DATA_NODE_COUNT);
+ }
+
+ @Before
+ public void restoreDataNodes() {
+ // The omitted-seed case leaves a node stopped. Restore it without
restarting healthy nodes,
+ // including when the previous case failed during its rolling restart.
+ List<Integer> restartedNodes = new ArrayList<>();
+ for (int index = 0; index < DATA_NODE_COUNT; index++) {
+ if (!EnvFactory.getEnv().getDataNodeWrapper(index).isAlive()) {
+ EnvFactory.getEnv().startDataNode(index);
+ restartedNodes.add(index);
+ }
+ }
+ for (int index = 0; index < DATA_NODE_COUNT; index++) {
+ awaitStatus(index, NodeStatus.Running);
+ }
+ // A Running heartbeat does not prove that a restarted node can serve the
next case's clients.
+ for (int index : restartedNodes) {
+ awaitLogin(index);
+ }
}
- @After
- public void tearDown() {
+ @AfterClass
+ public static void tearDown() {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // With three Ratis replicas, a Session and SessionPool must keep reading
the sole stored row
Review Comment:
Scenario: With three Ratis replicas, a Session and SessionPool must keep
reading the sole stored row while each DataNode is stopped and restarted, and
discover the current Running endpoints.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1059 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
Review Comment:
Initialize the class's fixed node configuration once for compatible methods.
Per-method data/state preparation or isolated namespaces preserve the
individual scenarios without repeated cluster startup.
<!-- it-runtime-rationale:c56099e483731cfb:1062 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
+ public static void setUpClass() throws Exception {
EnvFactory.getEnv().getConfig().getCommonConfig().setWalMode("SYNC");
// As this IT is only testing SessionPool itself, there's no need to
launch a large cluster
EnvFactory.getEnv().initClusterEnvironment(1, 1);
}
+ @Before
Review Comment:
Use the scenario-specific database consistently in writes, pipe filters and
expectations so asynchronous cleanup from a previous method cannot contaminate
the shared cluster.
<!-- it-runtime-rationale:c56099e483731cfb:1063 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/SessionSeedNodeFallbackIT.java:
##########
@@ -127,6 +151,8 @@ public void testQueriesDuringRollingRestart() throws
Exception {
}
}
+ // Leave only node 1 in the clients' snapshots, then stop it after omitted
seed node 0 recovers;
Review Comment:
Scenario: Leave only node 1 in the clients' snapshots, then stop it after
omitted seed node 0 recovers; business reconnection and background discovery
must fall back to seed 0 and retain both seeds.
Record the preserved input and expected result explicitly for this case so
its regression boundary remains reviewable after the fixture/runtime changes.
<!-- it-runtime-rationale:c56099e483731cfb:1060 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
+ public static void setUpClass() throws Exception {
EnvFactory.getEnv().getConfig().getCommonConfig().setWalMode("SYNC");
// As this IT is only testing SessionPool itself, there's no need to
launch a large cluster
EnvFactory.getEnv().initClusterEnvironment(1, 1);
}
+ @Before
+ public void setUp() {
+ database = "root.session_pool_" + NEXT_DATABASE_ID.incrementAndGet();
+ }
+
@After
public void tearDown() throws Exception {
+ dropDatabaseIfExists(database);
Review Comment:
Remove this method's test-owned data/schema after execution while retaining
class-owned nodes. The next case prepares its own input and cannot inherit the
previous result.
<!-- it-runtime-rationale:c56099e483731cfb:1064 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -19,7 +19,9 @@
package org.apache.iotdb.session.it.pool;
import org.apache.iotdb.commons.cluster.NodeStatus;
+import org.apache.iotdb.isession.ISession;
Review Comment:
Retain the existing scenario lifecycle while adding the supporting
imports/state for the bounded polling, Session reuse or diagnostics changes in
this class.
<!-- it-runtime-rationale:c56099e483731cfb:1061 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
+ public static void setUpClass() throws Exception {
EnvFactory.getEnv().getConfig().getCommonConfig().setWalMode("SYNC");
// As this IT is only testing SessionPool itself, there's no need to
launch a large cluster
EnvFactory.getEnv().initClusterEnvironment(1, 1);
}
+ @Before
+ public void setUp() {
+ database = "root.session_pool_" + NEXT_DATABASE_ID.incrementAndGet();
+ }
+
@After
public void tearDown() throws Exception {
+ dropDatabaseIfExists(database);
+ }
+
+ @AfterClass
Review Comment:
Destroy the class-owned cluster after all compatible scenarios finish, so
individual methods avoid repeated process startup/teardown.
<!-- it-runtime-rationale:c56099e483731cfb:1065 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -106,13 +138,14 @@ public void insert() {
}
}
+ // An invalid device path is rejected without leaving the pool unusable.
Review Comment:
Scenario: An invalid device path is rejected without leaving the pool
unusable.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1068 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
+ public static void setUpClass() throws Exception {
EnvFactory.getEnv().getConfig().getCommonConfig().setWalMode("SYNC");
// As this IT is only testing SessionPool itself, there's no need to
launch a large cluster
EnvFactory.getEnv().initClusterEnvironment(1, 1);
}
+ @Before
+ public void setUp() {
+ database = "root.session_pool_" + NEXT_DATABASE_ID.incrementAndGet();
+ }
+
@After
public void tearDown() throws Exception {
+ dropDatabaseIfExists(database);
+ }
+
+ @AfterClass
+ public static void tearDownClass() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ private void dropDatabaseIfExists(String databasePath) throws Exception {
Review Comment:
Reuse the scenario-owned Session for repeated writes/flushes, with closure
before cluster reset or restart so recovery uses fresh clients.
<!-- it-runtime-rationale:c56099e483731cfb:1066 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -60,19 +65,46 @@ public class SessionPoolIT {
private static final Logger logger =
LoggerFactory.getLogger(SessionPoolIT.class);
private static final long DEFAULT_QUERY_TIMEOUT = -1;
+ private static final AtomicInteger NEXT_DATABASE_ID = new AtomicInteger();
- @Before
- public void setUp() throws Exception {
+ private String database;
+
+ @BeforeClass
+ public static void setUpClass() throws Exception {
EnvFactory.getEnv().getConfig().getCommonConfig().setWalMode("SYNC");
// As this IT is only testing SessionPool itself, there's no need to
launch a large cluster
EnvFactory.getEnv().initClusterEnvironment(1, 1);
}
+ @Before
+ public void setUp() {
+ database = "root.session_pool_" + NEXT_DATABASE_ID.incrementAndGet();
+ }
+
@After
public void tearDown() throws Exception {
+ dropDatabaseIfExists(database);
+ }
+
+ @AfterClass
+ public static void tearDownClass() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ private void dropDatabaseIfExists(String databasePath) throws Exception {
+ try (ISession session = EnvFactory.getEnv().getSessionConnection()) {
+ boolean exists;
+ try (SessionDataSet dataSet =
+ session.executeQueryStatement("SHOW DATABASES " + databasePath)) {
+ exists = dataSet.hasNext();
+ }
+ if (exists) {
+ session.deleteDatabase(databasePath);
+ }
+ }
+ }
+
+ // Concurrent inserts return all borrowed sessions to the pool after
completing.
Review Comment:
Scenario: Concurrent inserts return all borrowed sessions to the pool after
completing.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1067 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -158,13 +193,15 @@ public void incorrectExecuteQueryStatement() {
}
}
+ // Concurrent point queries complete and release every result set to the
pool.
Review Comment:
Scenario: Concurrent point queries complete and release every result set to
the pool.
Record the preserved input and expected result explicitly for this case so
its regression boundary remains reviewable after the fixture/runtime changes.
<!-- it-runtime-rationale:c56099e483731cfb:1070 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -158,13 +193,15 @@ public void incorrectExecuteQueryStatement() {
}
}
+ // Concurrent point queries complete and release every result set to the
pool.
@Test
public void executeQueryStatement() {
ISessionPool pool = EnvFactory.getEnv().getSessionPool(3);
correctQuery(pool, DEFAULT_QUERY_TIMEOUT);
pool.close();
}
+ // Point queries with an explicit timeout complete and release their
sessions.
Review Comment:
Scenario: Point queries with an explicit timeout complete and release their
sessions.
Record the preserved input and expected result explicitly for this case so
its regression boundary remains reviewable after the fixture/runtime changes.
<!-- it-runtime-rationale:c56099e483731cfb:1071 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -184,11 +221,12 @@ private void correctQuery(ISessionPool pool, long
timeoutInMs) {
SessionDataSetWrapper wrapper;
if (timeoutInMs == DEFAULT_QUERY_TIMEOUT) {
wrapper =
- pool.executeQueryStatement("select * from root.sg1.d1
where time = " + no);
+ pool.executeQueryStatement(
Review Comment:
Keep ten concurrent pool queries and pool occupancy assertions while
addressing the method-specific database, preventing residual data from other
shared-cluster methods from satisfying the query.
<!-- it-runtime-rationale:c56099e483731cfb:1072 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -125,6 +158,7 @@ public void incorrectSQL() {
}
}
+ // Unclosed query results occupy the pool and prevent queued requests from
completing.
Review Comment:
Scenario: Unclosed query results occupy the pool and prevent queued requests
from completing.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1069 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -243,13 +282,14 @@ public void executeRawDataQuery() {
}
}
+ // A query interrupted by a DataNode stop can be retried after the node
recovers.
Review Comment:
Scenario: A query interrupted by a DataNode stop can be retried after the
node recovers.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1074 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -208,13 +246,14 @@ private void correctQuery(ISessionPool pool, long
timeoutInMs) {
}
}
+ // Concurrent raw-data queries return the timestamp selected by each worker.
Review Comment:
Scenario: Concurrent raw-data queries return the timestamp selected by each
worker.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1073 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -345,6 +386,7 @@ public void tryIfTheServerIsRestartButDataIsGotten() {
}
}
+ // Writes fail while the DataNode is stopped and succeed after it restarts.
Review Comment:
Scenario: Writes fail while the DataNode is stopped and succeed after it
restarts.
Record the preserved input and expected result explicitly for this case so
its regression boundary remains reviewable after the fixture/runtime changes.
<!-- it-runtime-rationale:c56099e483731cfb:1076 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -320,14 +360,15 @@ public void tryIfTheServerIsRestart() throws
InterruptedException {
fail("should throw exception but not");
}
+ // A query whose result is already available releases its pool slot after
consumption.
Review Comment:
Scenario: A query whose result is already available releases its pool slot
after consumption.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1075 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -410,6 +453,7 @@ public void testClose() {
// session.
}
+ // Pool setters update their corresponding observable configuration values.
Review Comment:
Scenario: Pool setters update their corresponding observable configuration
values.
Record the preserved input and expected result explicitly for this case so
its regression boundary remains reviewable after the fixture/runtime changes.
<!-- it-runtime-rationale:c56099e483731cfb:1079 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -375,7 +417,7 @@ private void write10Data(ISessionPool pool, boolean
failWhenThrowException) {
for (int i = 0; i < 10; i++) {
try {
pool.insertRecord(
- "root.sg1.d1",
+ database + ".d1",
Review Comment:
Write the same ten single-record requests into the method's isolated
database, preserving both normal writes and intentional failure handling in the
pool scenarios.
<!-- it-runtime-rationale:c56099e483731cfb:1077 -->
##########
integration-test/src/test/java/org/apache/iotdb/session/it/pool/SessionPoolIT.java:
##########
@@ -389,13 +431,14 @@ private void write10Data(ISessionPool pool, boolean
failWhenThrowException) {
}
}
+ // Closing a pool rejects later writes with the closed-pool error.
Review Comment:
Scenario: Closing a pool rejects later writes with the closed-pool error.
Keep this case's expected result and regression boundary explicit while
adapting its shared fixture/client calls; the exact assertions remain at this
method.
<!-- it-runtime-rationale:c56099e483731cfb:1078 -->
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBRegionReadyAfterRestartTableIT.java:
##########
@@ -47,6 +47,8 @@ public class IoTDBRegionReadyAfterRestartTableIT {
@BeforeClass
public static void setUpClass() {
+ // Keep the pre-restart row durable independently of Windows process-stop
timing.
Review Comment:
Use SYNC WAL for the upstream Region-readiness restart regression. On
Windows the process stop can terminate before ASYNC WAL persists the first
acknowledged row; a faster stop/start must not make input durability depend on
scheduling. Keep the original 1C3D topology and all Running-region and exact
two-row assertions without adding a flush to the recovery path.
<!-- it-runtime-rationale:c56099e483731cfb:1080 -->
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBRegionReadyAfterRestartTableIT.java:
##########
@@ -55,6 +57,7 @@ public static void tearDownClass() {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // Persist one row, restart all nodes, then require Running Regions and both
rows after a write.
Review Comment:
Scenario: Persist one row, restart all nodes, then require Running Regions
and both rows after a write.
Document the preserved upstream regression: persist a first row, restart all
nodes, verify every reported Region is Running, then write and read both rows
exactly. Only the fixture makes durability explicit; the test body and its
readiness/recovery checks are unchanged.
<!-- it-runtime-rationale:c56099e483731cfb:1081 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]