jt2594838 commented on code in PR #19242:
URL: https://github.com/apache/iotdb/pull/19242#discussion_r4560338359
##########
integration-test/src/test/java/org/apache/iotdb/db/it/cq/IoTDBCQExecIT.java:
##########
@@ -65,21 +70,25 @@ public static void tearDown() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // A wildcard CQ copies only readable fields, observes revoke/grant, and
rejects a deleted owner.
@Test
public void testCQExecutionWithReadDataPermission() throws Exception {
testCQExecutionWithReadDataPermission(false, false);
}
+ // An aligned wildcard CQ filters unreadable fields and rechecks owner
permissions per window.
Review Comment:
Preserve the upstream CQ permission regression while merging its required
RPC/status imports with the existing per-DataNode result polling. Document this
wrapper's actual permission scenario; retain the original resampling comment at
testCQExecution1. The upstream RPC sequence and assertions are unchanged. The
complete CQ execution classes and CQ validation class pass in both SimpleIT and
ClusterIT.
<!-- it-runtime-rationale:1f02ff593eedefe5:1089 -->
##########
integration-test/src/test/java/org/apache/iotdb/db/it/cq/IoTDBCQExecIT.java:
##########
@@ -65,21 +70,25 @@ public static void tearDown() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // A wildcard CQ copies only readable fields, observes revoke/grant, and
rejects a deleted owner.
Review Comment:
Preserve the upstream CQ permission regression while merging its required
RPC/status imports with the existing per-DataNode result polling. Document this
wrapper's actual permission scenario; retain the original resampling comment at
testCQExecution1. The upstream RPC sequence and assertions are unchanged. The
complete CQ execution classes and CQ validation class pass in both SimpleIT and
ClusterIT.
<!-- it-runtime-rationale:1f02ff593eedefe5:1088 -->
##########
integration-test/src/test/java/org/apache/iotdb/db/it/cq/IoTDBCQExecIT.java:
##########
@@ -65,21 +70,25 @@ public static void tearDown() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // A wildcard CQ copies only readable fields, observes revoke/grant, and
rejects a deleted owner.
@Test
public void testCQExecutionWithReadDataPermission() throws Exception {
testCQExecutionWithReadDataPermission(false, false);
}
+ // An aligned wildcard CQ filters unreadable fields and rechecks owner
permissions per window.
@Test
public void testCQExecutionWithReadDataPermissionAlignByDevice() throws
Exception {
testCQExecutionWithReadDataPermission(true, false);
}
+ // Explicit CQ targets reject missing source access and succeed when that
access is restored.
Review Comment:
Preserve the upstream CQ permission regression while merging its required
RPC/status imports with the existing per-DataNode result polling. Document this
wrapper's actual permission scenario; retain the original resampling comment at
testCQExecution1. The upstream RPC sequence and assertions are unchanged. The
complete CQ execution classes and CQ validation class pass in both SimpleIT and
ClusterIT.
<!-- it-runtime-rationale:1f02ff593eedefe5:1090 -->
##########
integration-test/src/test/java/org/apache/iotdb/db/it/cq/IoTDBCQExecIT.java:
##########
@@ -65,21 +70,25 @@ public static void tearDown() throws Exception {
EnvFactory.getEnv().cleanClusterEnvironment();
}
+ // A wildcard CQ copies only readable fields, observes revoke/grant, and
rejects a deleted owner.
@Test
public void testCQExecutionWithReadDataPermission() throws Exception {
testCQExecutionWithReadDataPermission(false, false);
}
+ // An aligned wildcard CQ filters unreadable fields and rechecks owner
permissions per window.
@Test
public void testCQExecutionWithReadDataPermissionAlignByDevice() throws
Exception {
testCQExecutionWithReadDataPermission(true, false);
}
+ // Explicit CQ targets reject missing source access and succeed when that
access is restored.
@Test
public void testCQExecutionWithExplicitTargetReadDataPermission() throws
Exception {
testCQExecutionWithReadDataPermission(false, true);
}
+ // Aligned explicit CQ targets retain positional mapping across permission
revoke/grant retries.
Review Comment:
Preserve the upstream CQ permission regression while merging its required
RPC/status imports with the existing per-DataNode result polling. Document this
wrapper's actual permission scenario; retain the original resampling comment at
testCQExecution1. The upstream RPC sequence and assertions are unchanged. The
complete CQ execution classes and CQ validation class pass in both SimpleIT and
ClusterIT.
<!-- it-runtime-rationale:1f02ff593eedefe5:1091 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]