Adar Dembo has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss ......................................................................
Patch Set 2: (3 comments) Seems like the path of least resistance. I was inclined to vote for removing the "orphan_blocks" logic (and dealing with the leakiness until we have a better GC story) until I read the part about the block cache interaction. http://gerrit.cloudera.org:8080/#/c/3719/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 115: ATTRIBUTE_WEAK bool g_is_gtest; This work on macOS? Line 1098: // HACK: when running in a test environment, we often instantaite many Nit: instantiate Line 1343: // and thus we may have to "skip over" some block IDs that are claimed.. Nit: extra period. -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
