Todd Lipcon has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3719/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 115: ATTRIBUTE_WEAK bool g_is_gtest; > This work on macOS? I think so... Dan or JD, can you confirm that this patch passes cfile-test on mac? -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes