Todd Lipcon has posted comments on this change. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3632/4/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 484: > nit: extra empty line Done Line 560: errors.push_back(Substitute("$0 does not have a majority of replicas in RUNNING state", > Not sure about that one, I've seen clusters that had more tombstone'd table This is only counting replicas that are part of the current configuration -- old tombstoned replicas aren't processed here (this is based on looping over the replica list generated from the master info) http://gerrit.cloudera.org:8080/#/c/3632/4/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 235: > nit: extra empty line? Done -- To view, visit http://gerrit.cloudera.org:8080/3632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec6590ba52548a9ee11d63269b134320b10809da Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
