Mike Percy has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestReplaceChangeConfigOperation ......................................................................
Patch Set 2: (1 comment) > RaftConsensusITest(line 594) That's fine without waiting because the client will automatically retry until the election is done. > RemoteBootStrapITest and DeleteTabletTest Yeah, same as above. This case was problematic because of the nature of the test, which is fairly unique. http://gerrit.cloudera.org:8080/#/c/3819/2/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: Line 141: RETURN_NOT_OK(GetLastOpIdForEachReplica(tablet_id, { replica }, opid_type, timeout, &op_ids)); > Was this styling issue or any impact in the way vector is passed in ? Just a style issue (see commit message) ... less lines == easier to read. -- To view, visit http://gerrit.cloudera.org:8080/3819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib91b5cc974656e82f670d6a938f537b63338d036 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
