Mike Percy has posted comments on this change.

Change subject: Fix flakiness in 
RaftConsensusITest.TestReplaceChangeConfigOperation
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3819/2//COMMIT_MSG
Commit Message:

Line 47: 
> Also a nit: You may want to link this commit to KUDU-1548 I triaged where I
Notice that the rest of the commit message is wrapped at 80 chars.

I'm not going to try to condense this part to 80 chars -- it will be totally 
unreadable. Generally speaking, it's not good style to go over 80 chars, but I 
think one reasonable exception is pasting in log messages like this one. It's 
at the bottom of the commit message, so by the time you get to this part in 
"git log" you've already read the important part.

Regarding KUDU-1548 thanks for filing it. It looks like that JIRA potentially 
has a bunch of different issues listed. It might be better to have separate 
JIRAs about each issue though. I'll add a link to it in the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/3819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib91b5cc974656e82f670d6a938f537b63338d036
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to