Todd Lipcon has posted comments on this change. Change subject: Fix block_manager-test running in some builds ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3733/3/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 196: dl > Does this need to be conditioned on NOT APPLE? don't think so, given we use 'dl' in kudu_test_main elsewhere in this CMakeLists http://gerrit.cloudera.org:8080/#/c/3733/3/src/kudu/util/test_util_prod.h File src/kudu/util/test_util_prod.h: Line 25: #include "kudu/gutil/macros.h" > What's this for? Done -- To view, visit http://gerrit.cloudera.org:8080/3733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a4025a3d859b139b74be997706bd27d0ba7b292 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
