Todd Lipcon has submitted this change and it was merged.

Change subject: build: Make 'download-thirdparty.sh' resilient to failure
......................................................................


build: Make 'download-thirdparty.sh' resilient to failure

Many contributors work at home on flaky internet connections. This
change does two things:

 - Use gtar on Mac, if available, as I've found it more resilient to
   failures than bsdtar. For example, I just spent 20 minutes debugging
   a build failure in cmake which was due to a truncated tar.

 - Exit if the script doesn't successfully extract, currently a warning
   prefixed with "Error" is logged but the process is left to fail with
   some unknown error later on

Change-Id: Ied07d236b1c9cd2eb78aef7ad372f8d835e09782
Reviewed-on: http://gerrit.cloudera.org:8080/3857
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <t...@apache.org>
---
M thirdparty/download-thirdparty.sh
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied07d236b1c9cd2eb78aef7ad372f8d835e09782
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to