Alexey Serbin has posted comments on this change. Change subject: [C++ client] doxygenized all C++ client API ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/client/callbacks.h File src/kudu/client/callbacks.h: Line 46: KuduLoggingCallback() { > Why do we need this? That's the fun part -- we either need this or call the auto-instantiated constructor of this calls in constructors of the derived classes. Otherwise, the client_samples test fails to compile. I thought changing the derived classes would be considered as a 'style change'. So, returned back this. If speaking the best option here, what do you think is the best one: keep this piece of code (kind of strange) or call the KuduLoggingCallback() in the constructors of all the derived classes? Per our discussion, I'm returning the piece of code back. http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/util/slice.h File src/kudu/util/slice.h: Line 137: /// @note The data isn't actually modified, just the base/bounds of the slice. > Nit: restyled a bit: "Only the base and bounds of the slice are changed; th Done -- To view, visit http://gerrit.cloudera.org:8080/3840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0f82a6c8a500a892bc1daff8444e91191dab3af Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
