Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker ......................................................................
Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: Line 231: return client_state_map_bytes_; > I find this somewhat confusing vs just using a MemTrackerAllocator on the c I had forgotten about MemTrackerAllocator and I pointed David at Schema::NameToIndexMap, which uses an STLCountingAllocator because there's no embedded MemTracker. I should have pointed him at LogBlockManager::BlockMap instead. That said, a memory_footprint() function means David could reuse his fancy ScopedMemTrackerUpdater class for the ResultTracker, so I don't think it's a big deal either way. -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
