Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker ......................................................................
Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: Line 231: return client_state_map_bytes_; I find this somewhat confusing vs just using a MemTrackerAllocator on the client_state_map_. Adar, since you looked at this earlier, do you understand this part of the patch? Why not just attach the allocators to the MemTracker? -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
