Mike Percy has posted comments on this change. Change subject: Timestamp::FromUint64 should return void ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3943/1/src/kudu/common/timestamp.h File src/kudu/common/timestamp.h: Line 61: void FromUint64(uint64_t value); > hrm, maybe better to just remove this and use: ts = Timestamp(value) instea I don't know if it helps to not provide this mutation method because we also have bool DecodeFrom(Slice *input), as well as symmetrical methods ToUint64() and EncodeTo(faststring* s) -- To view, visit http://gerrit.cloudera.org:8080/3943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
