Mike Percy has submitted this change and it was merged. Change subject: Timestamp::FromUint64 should return void ......................................................................
Timestamp::FromUint64 should return void It does no validation, can't fail, and has the same signature as one of Timestamp's explicit constructors. Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e Reviewed-on: http://gerrit.cloudera.org:8080/3943 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/common/timestamp.cc M src/kudu/common/timestamp.h M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/tablet_bootstrap.cc 4 files changed, 5 insertions(+), 7 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98d487abb7b9e947b6c8c0a291812f790407242e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>