Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata ......................................................................
Patch Set 6: (2 comments) TFTR mpercy/dan, I have posted the new diffs under https://gerrit.cloudera.org/#/c/3955/, and decided to abandon this patch. PS: I tried to use same Change-Id as this one in my commit message to keep everything in one thread, but failed to do so because I got the new link when I published the new set of diffs. http://gerrit.cloudera.org:8080/#/c/3823/6/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: Line 109: const Partition partition_locked() const { > Is this the right return type? Seems weird to return const by value. Yeah, please ignore this change altogether, I have posted a new review with the new fix we had discussed earlier this week, and I am gonna abandon this change. http://gerrit.cloudera.org:8080/#/c/3823/6/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: Line 211: peer->tablet_metadata()->schema()); > Note: schema_ is also modified in TabletMetadata::LoadFromSuperBlock() Yes, but schema_ is not race-prone in that it has atomic pointer swap to new schema_ and also keeps history of stale schema_. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
