Dinesh Bhat has posted comments on this change.

Change subject: KUDU-1500: Data race in 
RaftConsensusITest.TestCorruptReplicaMetadata
......................................................................


Patch Set 6:

(1 comment)

TFTR MIke, this is still WIP, I uploaded one missing piece from my previous 
patchset to confirm jenkins test suite pass. I will upload another patchset 
today.

http://gerrit.cloudera.org:8080/#/c/3823/4/src/kudu/tablet/tablet_metadata.h
File src/kudu/tablet/tablet_metadata.h:

Line 142:   const PartitionSchema partition_schema_locked() const {
> I don't think this is needed anymore if we make PartitionSchema::PartitionD
I think I had missed out one important callsite in ListTablets(), while 
cleaning up the changes. I am inclined to keep this routine and 
PartitionDebugString as it is since this routine is called by 2 other callers 
now. This is still WIP as I uploaded the patch only to see if kudu jenkins test 
suite is happy,


-- 
To view, visit http://gerrit.cloudera.org:8080/3823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to