Todd Lipcon has posted comments on this change.

Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value
......................................................................


Patch Set 1:

(2 comments)

Thanks for fixing this. Just a small style nit.

http://gerrit.cloudera.org:8080/#/c/3970/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java:

Line 75:       // Try adding three columns, where one has default value, 
nullable and Timestamp with default value
nit: would you mind wrapping this line to 100 columns or less?


Line 79:           .addColumn("testaddmulticolTimestampcol", Type.TIMESTAMP, 
(System.currentTimeMillis() * 1000));
same as above


-- 
To view, visit http://gerrit.cloudera.org:8080/3970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a9ef473af3f205b33e6ef6061a29a362435a4c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to