Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: Line 57: for (const auto& gflag : action.gflags) { what about using google::DescribeOneFlag for this? It handles nice line-wrapping, etc, and also already includes support for printing the default, etc http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: Line 203: tablet_print_peer_uuids.name = "print_uuids"; I think print_peer_uuids would be better Line 204: tablet_print_peer_uuids.description = "Print the uuids from a tablet's Raft configuration"; UUIDs of the peers -- To view, visit http://gerrit.cloudera.org:8080/3969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfab2561e066f00fe56eb4f5d6d6ccbbb2dcbed5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
